Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WindowScroller to be used with scroll containers besides window? #474

Closed
andrewbranch opened this issue Nov 18, 2016 · 6 comments
Closed
Assignees

Comments

@andrewbranch
Copy link
Contributor

Wondering if you would consider a PR adding a scrollElement (name up for debate) prop to WindowScroller such that it could be used with containers that are neither window nor constrained only to the boundaries of a fully on-screen list. (As an example, imagine an app layout with multiple independently scrolling side-by-side panels.)

At a super quick glance, it looks like instances of window in WindowScroller could fairly easily be replaced with a custom element, but I haven't yet tried it, and I wanted to see if it had already been attempted, or if you knew of a reason why it couldn't be done. Or if you would be terribly opposed to the idea since it could make "WindowScroller" a misnomer. 😛

I'm probably going to give it a shot either way, but if it's something you're interested in incorporating, I can let you know how it goes and eventually open a PR.

@bvaughn
Copy link
Owner

bvaughn commented Nov 19, 2016

As an example, imagine an app layout with multiple independently scrolling side-by-side panels.

WindowScroller is unique because it allows the top-level browser scrollbar to control the position of windowed content. What you're describing sounds to me like a couple of vanilla, side-by-side Lists. (They can be independently scrolled.) I imagine you wouldn't want the browser's scrollbar to control one, so the only useful function of WindowScroller is not applicable. 😁

Maybe I'm misunderstanding you?

@bvaughn
Copy link
Owner

bvaughn commented Nov 19, 2016

In other words, why not this: https://plnkr.co/edit/A2zDoCWQTvzwW1C53bhS?p=preview

@andrewbranch
Copy link
Contributor Author

Yeah, that's not quite it. What I meant to describe was a layout like this.

@bvaughn
Copy link
Owner

bvaughn commented Nov 19, 2016

Oh interesting. I see.

That layout could be accomplished by providing your own cellRangeRenderer. (Doing that really gives you a ton of extra control over the innards of the list/grid/whatever.) But it would be more straight forward to do with something like WindowScroller. Hm... sure, share a PR. 😄 Happy to review it.

@andrewbranch
Copy link
Contributor Author

Cool! Appreciate the feedback so far. I’ll let you know what happens!

@bvaughn
Copy link
Owner

bvaughn commented Jan 17, 2017

Released in 8.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants