-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WindowScroller to be used with scroll containers besides window? #474
Comments
Maybe I'm misunderstanding you? |
In other words, why not this: https://plnkr.co/edit/A2zDoCWQTvzwW1C53bhS?p=preview |
Yeah, that's not quite it. What I meant to describe was a layout like this. |
Oh interesting. I see. That layout could be accomplished by providing your own |
Cool! Appreciate the feedback so far. I’ll let you know what happens! |
Released in 8.10.0 |
Wondering if you would consider a PR adding a
scrollElement
(name up for debate) prop to WindowScroller such that it could be used with containers that are neither window nor constrained only to the boundaries of a fully on-screen list. (As an example, imagine an app layout with multiple independently scrolling side-by-side panels.)At a super quick glance, it looks like instances of
window
in WindowScroller could fairly easily be replaced with a custom element, but I haven't yet tried it, and I wanted to see if it had already been attempted, or if you knew of a reason why it couldn't be done. Or if you would be terribly opposed to the idea since it could make "WindowScroller" a misnomer. 😛I'm probably going to give it a shot either way, but if it's something you're interested in incorporating, I can let you know how it goes and eventually open a PR.
The text was updated successfully, but these errors were encountered: