Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollToIndex does not account for horizontal scrollbar height #543

Closed
implausible opened this issue Jan 18, 2017 · 4 comments
Closed

scrollToIndex does not account for horizontal scrollbar height #543

implausible opened this issue Jan 18, 2017 · 4 comments
Labels
bug

Comments

@implausible
Copy link
Contributor

When using scrollToIndex with the auto scrollToAlignment, react-virtualized scrolls to the row without checking horizontal scrollbar height. This causes any scrollToIndex events at the bottom of the grid not to fully scroll rows into view as they are obscured by the horizontal scrollbar. This was discovered/tested in chrome.

https://plnkr.co/edit/fe24AK90QAwzXOGA2ZvD?p=preview
@bvaughn
Copy link
Owner

bvaughn commented Jan 26, 2017

Nice repro Plnkr! Thanks for putting one together that so clearly shows the problem. 😄

@bvaughn bvaughn added the bug label Jan 26, 2017
@zsherman
Copy link

zsherman commented Feb 20, 2017 •
edited
Loading

+1 also seeing this on rv@next without horizontal scrollbars

@bvaughn
Copy link
Owner

bvaughn commented Feb 21, 2017

Fixed in 9.0.3

@bvaughn bvaughn closed this as completed Feb 21, 2017
@barbalex
Copy link

I just updated to v9.0.4 and still need to set overflow-x: hidden on .ReactVirtualized__Grid to see the list row that was scrolled to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bvaughn @barbalex @zsherman @implausible