Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed columns in MultiGrid aren't scrollable #648

Closed
cp opened this issue Apr 10, 2017 · 10 comments
Closed

Fixed columns in MultiGrid aren't scrollable #648

cp opened this issue Apr 10, 2017 · 10 comments
Assignees

Comments

@cp
Copy link

cp commented Apr 10, 2017

Hello! I recently brought this up in the Slack channel and wanted to file a ticket here as a way to document the issue to reference internally at my company, as well as possibly start a discussion here.

When using MultiGrid, fixed columns (i.e. the lowerLeftGrid) aren't scrollable. As Brian mentioned in Slack this was a technical limitation caused by issues using ScrollSync to sync 2 grids. This begins to be an issue when anywhere between a good amount of our columns are fixed: it's not obvious to the user that they can't scroll on them.

I recently tried out a potential fix locally, and only found a couple small issues when syncing two Grids. I'm planning on fixing them and opening a PR unless there's any objections.

@bvaughn
Copy link
Owner

bvaughn commented Apr 10, 2017

Happy to review a PR that fixes this!

@bvaughn
Copy link
Owner

bvaughn commented Apr 27, 2017

No time pressure on this or anything. But since it's not on my plate, I'm going to clear it out of the open issues list. If you find time to submit a PR for this I'll be happy to review it!

@bvaughn bvaughn closed this as completed Apr 27, 2017
@fc
Copy link

fc commented May 1, 2017

hey @cp, any luck with a PR on this?

@danalloway
Copy link
Contributor

@cp any update on this? want to explore a fix as well and would love for a head-start based on what you've found so far, care to share?

@karmajunkie
Copy link

+1 for a PR on this, or even just some notes about how to solve it...

@danalloway
Copy link
Contributor

danalloway commented Jun 22, 2017

for discussion: https://github.com/danalloway/react-virtualized/tree/scroll-fixed-sections

not sure of any side affects yet, but it works in a project I'm in the middle of

@danalloway
Copy link
Contributor

danalloway commented Jun 22, 2017

when MultiGrid is in fixed mode (cols, rows or both) the grid section that is fixed needs an onScroll prop, but it can't use the one that the main content grid uses because that updates bothscrollLeft and scrollTop.

so, in theory, two new methods are needed _onScrollLeft and _onScrollTop, that handle updating each value independently.

_onScrollLeft is what a fixed row will use and _onScrollTop is what a fixed column will use.

after that we adjust the styles for each section to allow overflow visibility in the proper direction and you should have a basic working example of fixed section scrolling.

this may be the incorrect way of doing it, but it is one way to get something working with minimal effort

@bvaughn
Copy link
Owner

bvaughn commented Jun 22, 2017

I'm still happy to review a PR for this but don't plan to take any action on creating one myself. 😄

@danalloway
Copy link
Contributor

#708

@cp
Copy link
Author

cp commented Jun 24, 2017

Hey friends, sorry about the lack of update here from me. Unfortunately I went back to using HTML tables as opposed to RV, and wasn't able to find a reasonable path forward with this issue. Best of luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants