Feature request: Externalize ArrowKeyStepper state

[mking-clari]

I would like to manage the scrollToColumn/scrollToRow state in Redux. I see that I can set the ArrowKeyStepper's scrollToColumn/scrollToRow via its props. In addition, I would like an onChange function to capture scrollToColumn/scrollToRow changes.

I think ReactMeasure is a good example of a component that provides both options (function child vs onMeasure).

[bvaughn]

ArrowKeyStepper works with a child function, so you already have access to the scrolled-to row and column when they change.

  <ArrowKeyStepper
    columnCount={columnCount}
    rowCount={rowCount}
  >
    {({ onSectionRendered, scrollToColumn, scrollToRow }) => {
      // Do whatever you want with scrollToColumn and scrollToRow here
      return (
        <Grid
          scrollToColumn={scrollToColumn}
          scrollToRow={scrollToRow}
          onSectionRendered={onSectionRendered}
          {...otherGridProps}
        />
      );
    }}
  </ArrowKeyStepper>

[mking-clari]

If I call a Redux action there, that causes a setState function to be called within render, which results in a React warning. I'll create an example repo to show it

[mking-clari]

Here is the issue (let me know if you know a better way to transfer the child args to Redux).

Repo: https://github.com/mking-clari/stepper-warning

[bvaughn]

If I call a Redux action there, that causes a setState function to be called within render, which results in a React warning. I'll create an example repo to show it

You could dispatch your action on the next tick to avoid this.

[bvaughn]

Anyway, I'm pretty swamped at the moment so I haven't been taking on feature requests for this lib. Happy to review a PR if you'd like to submit one though. 😄

[mking-clari]

I'll close this for now. If I have time I'll open a PR. Thanks for taking the time to review!

[bvaughn]

Sounds reasonable. Thanks for understanding!