You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{
name: "Use -u=patch to upgrade thanos package",
do: func(t *testing.T, g *goEnv, p *testProject) {
if !goVersion.LessThan(version.Go116) {
// TODO(bwplotka): Fix. It's not critical feature though to block release.
t.Skip("From Go 1.16 behavior changed: get: can't query version \"patch\" of module github.com/thanos-io/thanos/cmd/thanos: no existing version is required")
}
fmt.Println(g.ExecOutput(t, p.root, bingoPath, "get", "--upatch", "thanos"))
},
expectRows: []row{
// TODO(bwplotka) This will be painful to maintain, but well... improve it
{name: "thanos", binName: "thanos-v0.21.1", pkgVersion: "github.com/thanos-io/thanos/cmd/thanos@v0.21.1"},
},
expectBinaries: []string{"thanos-v0.21.1"},
},
Next steps:
Potentially remove u and upatch options with something home-made that tries to get literally latest commit/tag of provided repo.
The text was updated successfully, but these errors were encountered:
Removing -u test too for now as it's misleading most of the time.
{
name: "Use -u to upgrade thanos package",
do: func(t *testing.T, g *goEnv, p *testProject) {
fmt.Println(g.ExecOutput(t, p.root, bingoPath, "get", "-u", "thanos"))
},
expectRows: []row{
// TODO(bwplotka) This will be painful to maintain, but well... improve it
{name: "thanos", binName: "thanos-v0.21.1", pkgVersion: "github.com/thanos-io/thanos/cmd/thanos@v0.21.1"},
},
expectBinaries: []string{"thanos-v0.21.1"},
},
bwplotka
changed the title
-upatch and -u options does not work as expected
-upatch and -u options does not work as expected; bring them back
Jul 20, 2021
We had to skip test even:
Next steps:
The text was updated successfully, but these errors were encountered: