Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Template Group with empty ID is available for filtering and for adding templates in group #1236

Closed
rennervo opened this issue Aug 28, 2018 · 4 comments

Comments

@rennervo
Copy link
Collaborator

rennervo commented Aug 28, 2018

Steps:

  1. In config.json create a template group with translate and with an empty ID
  2. In CS UI go to Images
    3.1. Click to a drop-down list of filtering by groups
    3.2. Go to a sidebar of any image and click to an icon of group editing

Actual result: Template group with empty ID is available for select
Expected result: Template group with empty ID s not in the list
Template Group empty ID.png

@elenaustyugova
Copy link
Collaborator

elenaustyugova commented Aug 29, 2018

To investigate whether it is possible to validate it in json scheme.

@elenaustyugova
Copy link
Collaborator

@HeyRoach please check if there is missing information about this configuration in config guide. If there is, please add necessary details.

@HeyRoach
Copy link
Contributor

HeyRoach commented Sep 4, 2018

For information:
add validation: id should contain at list 1 character,
translations might be '' , because it's up to the user

Test:
config_image_group

@HeyRoach HeyRoach assigned Nadya913 and unassigned HeyRoach Sep 4, 2018
@chewlite chewlite assigned chewlite and rennervo and unassigned Nadya913 and chewlite Sep 4, 2018
@rennervo
Copy link
Collaborator Author

rennervo commented Sep 4, 2018

Tested on 1245 in a simulator

@rennervo rennervo assigned HeyRoach and unassigned rennervo Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants