This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
fix(disk-offering): enable change disk offering for volume #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1316
💛 - Coveralls |
tamazlykar
suggested changes
Nov 7, 2018
| map((volume: Volume) => { | ||
|
|
||
| const diskofferingid = !isRoot(volume) && params.diskofferingid; | ||
| const size = (() => { |
There was a problem hiding this comment.
Why do you use a self-executing anonymous function?
| @@ -224,12 +227,12 @@ export class VolumesEffects { | |||
| @Effect() | |||
| resizeVolume$: Observable<Action> = this.actions$.pipe( | |||
| ofType(volumeActions.RESIZE_VOLUME), | |||
| mergeMap((action: volumeActions.ResizeVolume) => { | |||
| withLatestFrom(this.store.pipe(select(fromDiskOfferings.selectEntities))), | |||
| switchMap(([action, diskOfferings]: [volumeActions.ResizeVolume, any]) => { | |||
There was a problem hiding this comment.
Don't use any. We have NgrxEntities interface for this case.
| @@ -32,6 +32,9 @@ import * as fromVolumes from './volumes.reducers'; | |||
| import * as snapshotActions from '../../snapshots/redux/snapshot.actions'; | |||
| // tslint:disable-next-line | |||
| import { VolumeDeleteDialogComponent } from '../../../shared/actions/volume-actions/volume-delete/volume-delete-dialog.component'; | |||
| import { isCustomized } from '../../../shared/models/offering.model'; | |||
| import * as fromDiskOfferings from '../../disk-offerings/redux/disk-offerings.reducers'; | |||
| import * as pickBy from 'lodash/pickBy'; | |||
There was a problem hiding this comment.
Do you use a Sort imports by modules?
| component.newSize = newVolumeSize; | ||
| spyOn(component.diskResized, 'emit').and.callThrough(); | ||
|
|
||
| const diskOffering = { |
| return null; | ||
| })(); | ||
|
|
||
| const requestParams = pickBy( |
tamazlykar
approved these changes
Nov 7, 2018
tamazlykar
approved these changes
Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #1368