This repository was archived by the owner on Apr 9, 2023. It is now read-only.
Feature/typescript #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
- Coverage 57.42% 53.76% -3.67%
===========================================
Files 21 21
Lines 101 93 -8
Branches 15 14 -1
===========================================
- Hits 58 50 -8
Misses 34 34
Partials 9 9
|
byCedric
force-pushed
the
feature/typescript
branch
from
2aed6fb to
a810273
Compare
|
Unfortunately, the conversion to typescript is blocked by the absolute imports issue. |
byCedric
force-pushed
the
feature/typescript
branch
from
f1cb10e to
7713c13
Compare
Unfortunately there are some unexpected behaviours with `.test.ts` files picking the default Jest types, instead of the custom types. Luckily, the `.test.tsx` files are working perfectly.
byCedric
force-pushed
the
feature/typescript
branch
from
7713c13 to
7b2e97b
Compare
This is only temporary and must be resolved before the refactoring to TypeScript can be merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Fixes #22
Additional context
This is a work in progress and should not be merged yet.