Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Set dual amp thresholds with other thresholds #142

Open
ryanhammonds opened this issue Sep 13, 2023 · 0 comments
Open

[ENH] Set dual amp thresholds with other thresholds #142

ryanhammonds opened this issue Sep 13, 2023 · 0 comments

Comments

@ryanhammonds
Copy link
Member

Currently, amp_threshes=(1, 2) kwarg must be passed to the burst_kwargs argument in order for it to be passed to ndsp's detect_bursts_dual_threshold. Currently, this is how amp_threshes must be set:

amp_thresholds = (1, 2)

burst_thresholds = {
   'burst_fraction': 0.5
}

bm = Bycycle(
   burst_method='amp',
   thresholds=burst_thresholds,
   burst_kwargs={'amp_threshes': amp_thresholds}
)

Instead of passing the amp_thresholds with burst_kwargs, it would make sense allow these to be set from the thresholds kwarg. Something like below, should be equivalent to above:

burst_thresholds = {
    'burst_fraction': 0.5,
    'amp_enter': 1.,
    'amp_exit': 2.
}

bm = Bycycle(
    burst_method='amp',
    thresholds=burst_thresholds
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant