Skip to content

Commit 19ffbbc

Browse files
authored
Re-enable armv7-sony-vita-newlibeabihf in CI. (#1408)
Re-enable armv7-sony-vita-newlibeabihf cross check in CI. Also, add a few comments.
1 parent b82df5d commit 19ffbbc

File tree

5 files changed

+18
-3
lines changed

5 files changed

+18
-3
lines changed

.github/workflows/main.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,7 @@ jobs:
226226
- run: cargo check -Z build-std --target=aarch64-unknown-nto-qnx710 --features=all-apis
227227
- run: cargo check -Z build-std --target=x86_64-pc-nto-qnx710 --features=all-apis
228228
- run: cargo check -Z build-std --target=armv6k-nintendo-3ds --all-features
229-
# Temporarily disable armv7-sony-vita-newlibeabihf, as it gets build errors.
230-
# - run: cargo check -Z build-std --target=armv7-sony-vita-newlibeabihf --features=all-apis
229+
- run: cargo check -Z build-std --target=armv7-sony-vita-newlibeabihf --features=all-apis
231230
- run: cargo check -Z build-std --target=powerpc64-ibm-aix --features=all-apis
232231
- run: cargo check -Z build-std --target=mipsel-unknown-linux-gnu --features=all-apis
233232
- run: cargo check -Z build-std --target=mips64el-unknown-linux-gnuabi64 --features=all-apis

src/buffer.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ use core::slice;
9393
/// If you see errors like
9494
/// "captured variable cannot escape `FnMut` closure body",
9595
/// use an explicit loop instead of `retry_on_intr`, assuming you're using
96-
/// that. See `error_retry_closure_uninit` in examples.rs.
96+
/// that. See `error_retry_closure_uninit` in examples/buffer_errors.rs.
9797
pub trait Buffer<T>: private::Sealed<T> {}
9898

9999
// Implement `Buffer` for all the types that implement `Sealed`.

src/ioctl/mod.rs

+4
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ use bsd as platform;
6565
/// drivers in the kernel, and safety depends on both sides agreeing and
6666
/// upholding the expectations of the other.
6767
///
68+
/// And, `ioctl` calls can read and write arbitrary memory and have arbitrary
69+
/// side effects. Callers must ensure that any memory accesses and side effects
70+
/// are compatible with Rust language invariants.
71+
///
6872
/// # References
6973
/// - [Linux]
7074
/// - [Winsock]

src/rand/getrandom.rs

+5
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,13 @@ pub use backend::rand::types::GetRandomFlags;
1212
/// This is a very low-level API which may be difficult to use correctly. Most
1313
/// users should prefer to use [`getrandom`] or [`rand`] APIs instead.
1414
///
15+
/// This function is implemented using a system call, and not the
16+
/// [vDSO mechanism] introduced in Linux 6.11. See [#1185] for details.
17+
///
1518
/// [`getrandom`]: https://crates.io/crates/getrandom
1619
/// [`rand`]: https://crates.io/crates/rand
20+
/// [vDSO mechanism]: https://lwn.net/Articles/983186/
21+
/// [#1185]: https://github.com/bytecodealliance/rustix/issues/1185
1722
///
1823
/// # References
1924
/// - [Linux]

src/runtime.rs

+7
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,14 @@
2929
//! program or what they're doing, but the features in this module generally
3030
//! can only be used by one entity within a process.
3131
//!
32+
//! All that said, there are some functions in this module would could
33+
//! potentially be stabilized and moved to other modules. See also the
34+
//! documentation for specific functions in the [`not_implemented`] module, and
35+
//! the discussion in [#1314].
36+
//!
3237
//! [Origin]: https://github.com/sunfishcode/origin#readme
38+
//! [`not_implemented`]: crate::not_implemented
39+
//! [#1314]: https://github.com/bytecodealliance/rustix/issues/1314
3340
//!
3441
//! # Safety
3542
//!

0 commit comments

Comments
 (0)