Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntitySet does not have feature="enable-serde" #10367

Closed
djmarcin opened this issue Mar 10, 2025 · 0 comments · Fixed by #10368
Closed

EntitySet does not have feature="enable-serde" #10367

djmarcin opened this issue Mar 10, 2025 · 0 comments · Fixed by #10368

Comments

@djmarcin
Copy link
Contributor

djmarcin commented Mar 10, 2025

Feature

EntitySet does not have the following annotation, despite appearing to be mostly a wrapper around a CompoundBitSet, which does. I'm hoping this is just an oversight?

#[derive(Clone, Default, PartialEq, Eq)]
#[cfg_attr(
    feature = "enable-serde",
    derive(serde_derive::Serialize, serde_derive::Deserialize)
)]

Benefit

Allows EntitySet to be used in Serializable data structures like PrimaryMap/SecondaryMap/etc.

Implementation

Add the missing annotation.

Alternatives

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant