Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap handling for Windows ARM64 #4992

Closed
Berrysoft opened this issue Oct 1, 2022 · 9 comments · Fixed by #9266
Closed

Trap handling for Windows ARM64 #4992

Berrysoft opened this issue Oct 1, 2022 · 9 comments · Fixed by #9266
Labels
wasmtime:platform-support Related to supporting a new platform in Wasmtime

Comments

@Berrysoft
Copy link
Contributor

Berrysoft commented Oct 1, 2022

After #4990 merged, we can build wasmtime for Windows ARM64, and it should work without trap handling.

We now need to add trap handling to make it totally work.

@Berrysoft
Copy link
Contributor Author

Berrysoft commented Oct 1, 2022

UnwindInfoKind::Windows => {
// TODO: support Windows unwind info on AArch64
None
}

@alexcrichton alexcrichton added the wasmtime:platform-support Related to supporting a new platform in Wasmtime label Oct 4, 2022
@hwoodiwiss
Copy link

hwoodiwiss commented Mar 4, 2023

Is this something that's being looked at actively at the moment, and would a community contribution be welcome?

@cfallin
Copy link
Member

cfallin commented Mar 4, 2023

No one has indicated they're working on it, so if you or anyone who is familiar with Windows on Arm is willing to build it, we'd very much welcome it!

@dpaoliello
Copy link
Contributor

It's hackathon week at Microsoft, so I'm going to have a go at this as my project...

@alexcrichton
Copy link
Member

Oh nice, that'd be great! If you have any questions feel free to reach out here or on Zulip

@dpaoliello
Copy link
Contributor

dpaoliello commented Sep 17, 2024

I have a draft PR: #9266

Update: I misread the stack, looks like it's a crash due to a "malformed function table during unwind" - investigating further...

@dpaoliello
Copy link
Contributor

Update: I got everything working (required a more careful reading of the spec and how wasmtime emits instructions).
PR has been published.

@cfallin
Copy link
Member

cfallin commented Sep 18, 2024

Very exciting, thanks @dpaoliello! It looks like Alex has looked at the PR at a high level; I'll do a detailed review.

@kpreisser
Copy link
Contributor

Thank you very much for implementing unwind support for Windows Arm64, and providing release artifacts!
When running the unit tests of wasmtime-dotnet on Windows 11 Version 23H2 Arm64 (using the wasmtime-dev-aarch64-windows-c-api.zip artifact of the latest dev release), all tests now succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:platform-support Related to supporting a new platform in Wasmtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants