Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Remove support for WebAssembly tables #8124

Merged

Conversation

jameysharp
Copy link
Contributor

Wasmtime no longer needs any of this infrastructure and neither should anybody else.

This diff is nearly identical to @bjorn3's version of the same change, except I didn't remove Uimm64, which has started being used in other places. I forgot bjorn3 had already tackled this part until after I was already done, but it's reassuring that we both made the same changes.

bjorn3@fb82ccb

Fixes #5532

Wasmtime no longer needs any of this infrastructure and neither should
anybody else.

This diff is nearly identical to @bjorn3's version of the same change,
except I didn't remove Uimm64, which has started being used in other
places. I forgot bjorn3 had already tackled this part until after I was
already done, but it's reassuring that we both made the same changes.

bjorn3@fb82ccb

Fixes bytecodealliance#5532
@jameysharp jameysharp requested a review from a team as a code owner March 13, 2024 21:46
@jameysharp jameysharp requested review from cfallin and removed request for a team March 13, 2024 21:46
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:docs cranelift:meta Everything related to the meta-language. labels Mar 13, 2024
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is good code motion that makes Cranelift maintenance easier while moving tables up a layer where they can benefit from other opts too. Thanks for pushing it forward.

@cfallin cfallin added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 14, 2024
@jameysharp jameysharp added this pull request to the merge queue Mar 14, 2024
Merged via the queue into bytecodealliance:main with commit c447833 Mar 14, 2024
19 checks passed
@jameysharp jameysharp deleted the stop-doing-cranelift-tables branch March 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:docs cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cranelift: Remove table_addr and tables from CLIF, move them into cranelift-wasm's Wasm -> CLIF lowering
2 participants