Support .wat files in the explore command
#8314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many on the `wasmtime` subcommands work with either `.wasm` or `.wat` files, but `explore` only works with `.wasm`. This change accepts `.wat` as well.
adambratschikaye
requested review from
alexcrichton
and removed request for
a team
fitzgen
reviewed
Apr 8, 2024
src/commands/explore.rs
Outdated
Comment on lines
37
to
38
| let wasm = wat::parse_bytes(&bytes) | ||
| .with_context(|| format!("failed to parse Wasm module: {}", self.module.display()))?; |
There was a problem hiding this comment.
Can you make sure that this also compiles and works for wasm binaries when the wat dependency isn't enabled? Something like the following:
#[cfg(feature = "wat")]
let bytes = wat::parse_bytes(bytes).map_err(|mut e| {
e.set_path(path);
e
})?;There was a problem hiding this comment.
Sorry I forgot wat was behind a feature. Fixed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many on the
wasmtimesubcommands work with either.wasmor.watfiles, butexploreonly works with.wasm. This change accepts.watas well.