Migrate the wasmtime-types crate to no_std #8485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is where no_std for Wasmtime starts to get a bit interesting. Specifically the
wasmtime-types
crate is the first crate that depends on some nontrivial crates that also need to be migrated tono_std
. This PR disables the default feature ofwasmparser
by default and additionally does the same forserde
. This enables them to compile inno_std
contexts by default and default features will be enabled elsewhere in this repository as necessary.This also opts to drop the
thiserror
dependency entirely in favor of a manualDisplay
implementation with a cfg'd implementation ofError
.As before CI checks are added for
wasmtime-types
with ano_std
target itself to ensure the crate and all dependencies all avoidstd
.cc #8341