You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For instance in Pytorch, we have function einsum that takes as std::string and a ArrayRef.
We used to have 2 java methods, one taking BytePointer and ArrayRef and another String and ArrayRef.
But since I added Vector to pointer types for c10::ArrayRef, we now have a java method taking BytePointer and ArrayRef and another taking String and Vector. The overload taking String and ArrayRef is lost, which could break some user code.
The text was updated successfully, but these errors were encountered:
If we have in C++:
and:
we generate:
If the function takes 2 arguments:
with:
we now generate:
Is this intentional ?
Shouldn't we generate all combinations ?
For instance in Pytorch, we have function
einsum
that takes asstd::string
and aArrayRef
.We used to have 2 java methods, one taking
BytePointer
andArrayRef
and anotherString
andArrayRef
.But since I added
Vector
to pointer types forc10::ArrayRef
, we now have a java method takingBytePointer
andArrayRef
and another takingString
andVector
. The overload takingString
andArrayRef
is lost, which could break some user code.The text was updated successfully, but these errors were encountered: