Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Attributes in types.Metadata response #1108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose Attributes in types.Metadata response #1108

wants to merge 1 commit into from

Conversation

DavidGamba
Copy link
Contributor

Fixes #1107

@xcoulon
Copy link
Member

xcoulon commented Mar 18, 2023

This looks good, but some tests fail because of the unexpected attributes in the resulting metadata (for example, here)

@DavidGamba
Copy link
Contributor Author

I apologize I haven't had the time to fix the tests. I'll get this fixed and let you know when to take another look.
Thanks @xcoulon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcoulon xcoulon xcoulon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose document attributes in types.Metadata response
2 participants
@DavidGamba @xcoulon