Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples to 1.4.0 #26

Merged
merged 11 commits into from
Jan 5, 2023
Merged

Update examples to 1.4.0 #26

merged 11 commits into from
Jan 5, 2023

Conversation

diarmidmackenzie
Copy link
Member

@diarmidmackenzie diarmidmackenzie commented Jan 4, 2023 •
edited
Loading

This PR updates all examples to A-Frame 1.4.0, and fixes various issues arising:

  • THREE.Math -> THREE.MathUtils
  • Move from aframe-teleport-controls (old, unmaintained, broken in A-Frame 1.4.0) to blink-controls (maintained).
  • A workaround for A-Frame issue 5203 (which looks like a regression in 1.4.0).
  • Patch ammo-debug-drawer to addresses various THREE deprecations (would be nice to move to 1.0.1, but that uses ES6-style import/export, so needs PR Move builds from browserify to webpack #22

Of the issues found upgrading to 1.4.0, the ones that aren't fixed are:

The branch that includes this PR is temporarily published at:
https://diarmidmackenzie.github.io/aframe-physics-system/examples/

@diarmidmackenzie diarmidmackenzie marked this pull request as ready for review January 4, 2023 18:55
@diarmidmackenzie diarmidmackenzie mentioned this pull request Jan 4, 2023
Closed
vincentfretin
vincentfretin requested changes Jan 5, 2023
View reviewed changes
Copy link
Member

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, I added some comments. I just reviewed the changes in this PR, I didn't test the examples myself.

examples/ammo/constraints.html Outdated Show resolved Hide resolved
examples/cannon/constraints.html Outdated Show resolved Hide resolved
@diarmidmackenzie diarmidmackenzie merged commit daf2633 into c-frame:master Jan 5, 2023
@diarmidmackenzie diarmidmackenzie deleted the update-examples-to-1.4.0 branch January 5, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentfretin vincentfretin vincentfretin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diarmidmackenzie @vincentfretin