Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author type on the image's informations #488

Closed
flob38 opened this issue Apr 8, 2019 · 3 comments
Closed

Add author type on the image's informations #488

flob38 opened this issue Apr 8, 2019 · 3 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request need community approval This point must be debated and approved by c2c community

Comments

@flob38
Copy link
Contributor

flob38 commented Apr 8, 2019

In the available informations for images, we have 2 sort of author : author of the document (the one who created the document on C2C) and the author of the image (the one who shooted it).
When displaying those info, we must use suitable labels.

image

@flob38 flob38 added the enhancement New feature or request label Apr 8, 2019
@flob38
Copy link
Contributor Author

flob38 commented Apr 8, 2019

Maybe it is only a problem of traduction.

<field-view :document="document" :field="fields.author" />
<label-value v-if="document.creator" :label="$gettext('creator')">
     <author-link :author="document.creator" />
</label-value>

@cbeauchesne
Copy link
Member

cbeauchesne commented Apr 8, 2019

First line : it's image author, which means the one who took the picture
Second line : it's the one who uploaded the picture on camptocamp.

We must ask community what are the best translations for them, and fix it on transifex.

I propose :

  • first line : Auteur de l'image
  • second line : Contributeur

Note that the first translation key (author) is hardcoded, as it comes from API. We can't change it.
The second translation key, creator, can be changed, and as it's actually missleading, must be changed. If we choose "contributeur" in french, we'll change translation key to contributor.

@cbeauchesne cbeauchesne added the need community approval This point must be debated and approved by c2c community label Apr 8, 2019
@cbeauchesne
Copy link
Member

Duplicated of #590, and it's fixed by #591. Sorry @flob38, I've forgotten that you have created this issue when I opened #590

@cbeauchesne cbeauchesne added the duplicate This issue or pull request already exists label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request need community approval This point must be debated and approved by c2c community
Projects
None yet
Development

No branches or pull requests

2 participants