Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search a route associated to an outing: add activity in the simple search filters #400

Closed
2 tasks
desnoes opened this issue Feb 8, 2018 · 3 comments
Closed
2 tasks
Labels
enhancement New feature or request imported from v6 Issue created on v6 repo stale Issue with no activity, will be close soon

Comments

@desnoes
Copy link

desnoes commented Feb 8, 2018

Many times, the search for the route taken during the outing is not sucessfull because the results do not correspond to the selected activities. As an example, try to find the ski routes associated to 'chamechaude'. Only climbing routes are returned.
It is needed to consider the selected activity in the simple search procedure. To do so:

  • modify \template\outing\edit.html (line 125) to add the selected activities
  • modify simplesearch.js to add the activity as a filter for the search query (cf. app.SimpleSearchController.prototype.createAndInitBloodhound_ starting in line 330

Modifications are also required on the API side: cf. issue 722

@cbeauchesne cbeauchesne transferred this issue from c2corg/v6_ui Apr 1, 2019
@cbeauchesne
Copy link
Member

Actually, I think that result must also depends on map. So there is two solutions :

  1. add activity and bbox in search service
  2. or use /routes?act&bbox

IMO, 2. is the best one, as it does not ask a modification on API.

@desnoes, @brunobesson, your opinion ?

@cbeauchesne cbeauchesne added enhancement New feature or request imported from v6 Issue created on v6 repo labels Apr 1, 2019
@stale
Copy link

stale bot commented Jun 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue with no activity, will be close soon label Jun 30, 2019
@stale
Copy link

stale bot commented Jul 14, 2019

This issue has been closed because it has not had recent activity. Do not hesitate to reopen it if necessary.

@stale stale bot closed this as completed Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request imported from v6 Issue created on v6 repo stale Issue with no activity, will be close soon
Projects
None yet
Development

No branches or pull requests

2 participants