-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation fails with node v0.12.0 #78
Comments
yes, I need to catch up now. Thanks for the issue report. |
+1 |
This is being addressed in #79 |
+1 |
Addressed by #79, CPU profiling is not working yet though. |
Do you expect there will be movement on this issue any time soon? I like node-webkit-agent and would feel sad to switch, but this is a blocker for us upgrading to Node v0.12. |
@macinjosh32 master branch has a working version for Node v0.12.x. Although, there wouldn't be CPU profiler, it is the last piece missing to get full support for 0.12.x. |
using 0.12.5 version of node -> npm install webkit-devtools-agent@0.3.1 gives the below error
CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
CXX(target) Release/obj.target/profiler/src/cpu_profiler.o |
@sandeshhegde83, did you ever resolve this? I'm running into the exact same issue, so if there is a known solution it would be great if you could share it 👍 |
I'm sorry you guys are running into these issues. Unfortunately, I haven't found time to work on this, but I would be happy to help if anyone of you want to tackle this problem. |
+1 |
npm install webkit-devtools-agent
/
CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
child_process: customFds option is deprecated, use stdio instead.
CXX(target) Release/obj.target/profiler/src/cpu_profiler.o
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:19:57: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle GetProfilesCount(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:20:51: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle GetProfile(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:21:52: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle FindProfile(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:22:55: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle StartProfiling(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:23:54: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle StopProfiling(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:1:
../src/cpu_profiler.h:24:58: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle DeleteAllProfiles(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
In file included from ../src/cpu_profiler.cc:2:
../src/profile.h:16:61: error: unknown type name 'AccessorInfo'
static Handle GetUid(Local property, const AccessorInfo& info);
^
../src/profile.h:17:63: error: unknown type name 'AccessorInfo'
static Handle GetTitle(Local property, const AccessorInfo& info);
^
../src/profile.h:18:65: error: unknown type name 'AccessorInfo'
static Handle GetTopRoot(Local property, const AccessorInfo& info);
^
../src/profile.h:19:68: error: unknown type name 'AccessorInfo'
static Handle GetBottomRoot(Local property, const AccessorInfo& info);
^
../src/profile.h:20:37: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
static Handle Delete(const Arguments& args);
^~~~~~~~~
v8::internal::Arguments
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here
class Arguments;
^
../src/cpu_profiler.cc:8:21: error: calling a protected constructor of class 'v8::HandleScope'
HandleScope scope;
^
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:816:13: note: declared protected here
V8_INLINE HandleScope() {}
^
../src/cpu_profiler.cc:10:62: error: 'New' is a private member of 'v8::PersistentBasev8::ObjectTemplate'
cpu_profiler_template_ = Persistent::New(ObjectTemplate::New());
^
/Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:572:23: note: declared private here
V8_INLINE static T* New(Isolate* isolate, T* that);
^
../src/cpu_profiler.cc:10:34: error: too few arguments to function call, expected 2, have 1; did you mean 'Profile::New'?
cpu_profiler_template_ = Persistent::New(ObjectTemplate::New());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Profile::New
../src/profile.h:13:24: note: 'Profile::New' declared here
static Handle New(const CpuProfile* profile);
^
../src/cpu_profiler.cc:11:31: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'?
cpu_profiler_template_->SetInternalFieldCount(1);
~~~~~~~~~~~~~~~~~~~~~~^~
.
../src/cpu_profiler.cc:11:33: error: no member named 'SetInternalFieldCount' in 'v8::Persistent<v8::ObjectTemplate,
v8::NonCopyablePersistentTraitsv8::ObjectTemplate >'
cpu_profiler_template_->SetInternalFieldCount(1);
~~~~~~~~~~~~~~~~~~~~~~ ^
../src/cpu_profiler.cc:13:62: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'?
Local cpuProfilerObj = cpu_profiler_template_->NewInstance();
~~~~~~~~~~~~~~~~~~~~~~^~
.
../src/cpu_profiler.cc:13:64: error: no member named 'NewInstance' in 'v8::Persistent<v8::ObjectTemplate,
v8::NonCopyablePersistentTraitsv8::ObjectTemplate >'
Local cpuProfilerObj = cpu_profiler_template_->NewInstance();
~~~~~~~~~~~~~~~~~~~~~~ ^
../src/cpu_profiler.cc:15:9: error: no matching function for call to 'NODE_SET_METHOD'
NODE_SET_METHOD(cpuProfilerObj, "getProfilesCount", CpuProfiler::GetProfilesCount);
^~~~~~~~~~~~~~~
/Users/mgawande/.node-gyp/0.12.0/src/node.h:240:25: note: expanded from macro 'NODE_SET_METHOD'
define NODE_SET_METHOD node::NODE_SET_METHOD
/Users/mgawande/.node-gyp/0.12.0/src/node.h:228:13: note: candidate function [with TypeName = v8::Localv8::Object] not viable: no known conversion
from 'Handlev8::Value (const v8::internal::Arguments &)' to 'v8::FunctionCallback' (aka 'void ()(const FunctionCallbackInfov8::Value &)')
for 3rd argument
inline void NODE_SET_METHOD(const TypeName& recv,
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: ** [Release/obj.target/profiler/src/cpu_profiler.o] Error 1
gyp ERR! build error
gyp ERR! stack Error:
make
failed with exit code: 2gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack at ChildProcess.emit (events.js:110:17)
gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:1067:12)
gyp ERR! System Darwin 13.4.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent
gyp ERR! node -v v0.12.0
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Darwin 13.4.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "webkit-devtools-agent"
npm ERR! node v0.12.0
npm ERR! npm v2.5.1
npm ERR! code ELIFECYCLE
npm ERR! webkit-devtools-agent@0.3.1 install:
node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the webkit-devtools-agent@0.3.1 install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the webkit-devtools-agent package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get their info via:
npm ERR! npm owner ls webkit-devtools-agent
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /Users/mgawande/Desktop/src/scratch/npm-debug.log
The text was updated successfully, but these errors were encountered: