Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genie download page not finishing load #10671

Open
alisman opened this issue Feb 27, 2024 · 1 comment · Fixed by cBioPortal/cbioportal-frontend#4863
Open

Genie download page not finishing load #10671

alisman opened this issue Feb 27, 2024 · 1 comment · Fixed by cBioPortal/cbioportal-frontend#4863
Assignees
Labels

Comments

@alisman
Copy link
Contributor

alisman commented Feb 27, 2024

If you look at network tab, you'll see that all requests eventually resolve but the spinner never goes away. Please investigate why that is. My hunch is that the genome nexus call (20s) is not being tracked properly.

https://genie.cbioportal.org/results/download?cancer_study_list=brca_akt1_genie_2019%2Cglioma_dfci_2020%2Cerbb2_genie_public%2Ccrc_public_genie_bpc%2Cnsclc_public_genie_bpc%2Cgenie_public%2Cmbc_genie_2020&tab_index=tab_visualize&profileFilter=mutations%2Ccna%2Cgistic%2Cstructural_variants&case_set_id=all&Action=Submit&gene_list=EGFR%250AERBB2%250AERBB3%250AERBB4%253A%2520MUT%253DS303F%253B

@alisman
Copy link
Contributor Author

alisman commented Mar 1, 2024

@gblaih good job on this one. i'm curious how you zero'd in on that code. this page now loads. However, i'm still seeing a huge amount of frontend latency and when i profile, i see this:
image

The orange is scripting and you can see that it's associated with what looks to me like mobx internals. What this suggests to me is that we are applying mobx on an enormous array when it's probably totally unnecessary. Mobx makes data observable but at great cost (when data is large) and often it's just the reference to a structure that really needs to be observable and not the internal data members. Lets discuss on Monday how to further improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants