Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tooltips for Altered and Unaltered group columns on comparison page #9718

Closed
2 tasks
alisman opened this issue Jul 27, 2022 · 3 comments · Fixed by cBioPortal/cbioportal-frontend#4649
Closed
2 tasks
Assignees

Comments

@alisman
Copy link
Contributor

alisman commented Jul 27, 2022

Example query

The frequencies listed in the Altered group and Unaltere group columns are percentage would appear to be a percentage of the overall number of samples in these respective groups. In fact, they are a percentage of samples what are profiled for the gene (corresponding to each row). For this reason, the denominator may change by row and the percentages can't always be compared row by row. We need to

  • Edit the tooltip of the column headers to indicate this:
    Altered group: Number (percentage) of samples in Altered group that are profiled for, and altered in, listed gene.

  • Add tooltip to each cell in row that indicates the same but prints the actual gene. E.g.:
    "Number (percentage) of samples in Altered group that are profiled for, and altered in, EGFR"

image

@alisman
Copy link
Contributor Author

alisman commented Jul 27, 2022

@jjgao please assign

@stale
Copy link

stale bot commented Oct 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 29, 2022
@jjgao
Copy link
Member

jjgao commented Jun 12, 2023

Good idea to make the tooltips more clear.

Here is a better example - genes with different denominators: https://bit.ly/45SpUMp - click Gene column to order.

I think we can add the denominators in the tooltip for the row, similar to the co-occurrence column, so instead of saying "Number (percentage) of samples in Altered group that are profiled for, and altered in, EGFR" we can say "x samples in Altered group are profiled for [gene name], y (z%) of which are altered in [gene name]"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants