-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database version Rename #28
Conversation
What other modules break by changing the external api for Using a separate version number than the core library that's published on npm might cause confusion later in time. With a small distributed set of contributors, reducing the number of variables at play can help with groking potential bugs or mismatches in versions. What if we used the version from package.json? |
@@ -66,9 +66,9 @@ function Cabal (storage, key, opts) { | |||
} | |||
|
|||
inherits(Cabal, events.EventEmitter) | |||
Cabal.prototype.getProtocolVersion = function (cb) { | |||
Cabal.prototype.getDatabaseVersion = function (cb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the code that changes the ~/.cabal/archives
dir name already in master, or can that get into this PR too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noffle it's not in master, but in the multi-cabal pr here cabal-club/cabal-cli#89
(i'm not sure how i would bring it into the cabal-core pr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, of course!
My thinking was "gosh it'd be nice if we could get in the db-dir changes so we can test that separately from the multi-cabal work".
i renamed protocol version to database version and used an int to represent it instead as it doesn't make sense to have minor & patch on something like this.
lmk what else we can do here before we merge into master
this will be required for cabal-cli's multi cabal pr