Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant crash upon changing layer order while paused #4514

Closed
4 tasks done
silo8811 opened this issue Oct 1, 2024 · 1 comment · Fixed by #4530
Closed
4 tasks done

Instant crash upon changing layer order while paused #4514

silo8811 opened this issue Oct 1, 2024 · 1 comment · Fixed by #4530
Labels
bug Something isn't working

Comments

@silo8811
Copy link

silo8811 commented Oct 1, 2024

Some information

Operating system: Win 11 build 22631
Java version: 23
Minecraft version: 1.20.4
Baritone version: 1.10.2
Other mods (if used): Cloth config api, fabric api (ofc) gamma utils, malilib

Exception, error or logs

Please find your latest.log or debug.log in this folder and attach it to the issue

Note I was on a server so I have (attempted) to censor out information not pertaining to the bug itsself

2024-10-01-1.log

How to reproduce

Step 1: Get yourself tools. A simple pick and shovel.
Step 2: Go to one random coordinate on the world and do sel 1
Step 3: Go to somewhere nearby but not too far. Then go underground and do sel 2
Step 4: Tell baritone set buildInLayers true
Step 5: Start baritone with sel ca
Step 6: Pause baritone with paws
Step 7: Tell baritone set layerOrder true (assuming it was false)
Step 8: Crash the game by doing unpaws

Modified settings

image

Final checklist

  • I know how to properly use check boxes
  • I have included the version of Minecraft I'm running, baritone's version and forge mods (if used).
  • I have included logs, exceptions and / or steps to reproduce the issue.
  • I have not used any OwO's or UwU's in this issue.
@silo8811 silo8811 added the bug Something isn't working label Oct 1, 2024
@ZacSharp
Copy link
Collaborator

ZacSharp commented Oct 3, 2024

Looks like (another case of) assuming an invariant which doesn't actually hold. If I correctly guessed to unobfuscated stack trace this is caused by code assuming that incorrectPositions only contains in-bounds positions while in reality the bounds might have changed since the bounds check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants