New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimated price is zero rather than None #1

Closed

Bre77 opened this issue Aug 26, 2024 · 1 comment

Contributor

Bre77 commented Aug 26, 2024 •

edited

Loading

When the library cannot calculate an average it returns 0, but this causes issues for Home Assistant because 0 is a valid price.

I believe this should return None instead. Home Assistant handles this as unknown, and it won’t get confused with an actual zero price.

aemonemdata/src/aemonemdata/aemonem.py

Line 223 in a874bda

current_30min_avg = 0

Bre77 changed the title ~~Estimated price is zero rather than nill~~ Estimated price is zero rather than None

Bre77 mentioned this issue

Return None instead of Zero #2

Merged

Owner

cabberley commented Aug 27, 2024

Thanks, have merged it and will push through new releases for the Python module and HA Integration shortly!

cabberley closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment