ObjectID.isValid function return true for number

[mjancarik]

Hi,

I have problem with ObjectID.isValid function which returns true for number. I think that number is not valid ObjectID or I miss something important. I found that behaviour when I update to v@2.0.1.

[mjancarik]

I found http://mongodb.github.io/node-mongodb-native/api-bson-generated/objectid.html

[niftylettuce]

Can you submit a PR to fix this?

[niftylettuce]

The PR #46 broke all tests. I am going to revert it in the interim.

I also noticed we need to merge this 418sec#2.

[supersime]

Hey there @niftylettuce I have a suggested resolution to this based on how the mongoose library has tackled this. They created a new method to address the issue, so they now have:

• isValidObjectId: Returns true if Mongoose can cast the given value to an ObjectId, or false otherwise.
• isObjectIdOrHexString Returns true if the given value is a Mongoose ObjectId (using instanceof) or if the given value is a 24 character hex string, which is the most commonly used string representation of an ObjectId.

Here is a great write-up on the issues they encountered: Automattic/mongoose#11419

Thanks!

[titanism]

@supersime it also seems that Mongoose will return true when it's an IP address, such as 192.168.1.20

[titanism]

> require('bson-objectid').isValid('192.168.1.20')
true
> require('mongoose').Types.ObjectId.isValid('192.168.1.20')
true

[titanism]

We should probably update this repo to use the approach with hex string and 24 char length as per isObjectIdOrHexString