Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Implement --no-ignore-vcs #969

Open
ken-matsui opened this issue Aug 12, 2024 · 3 comments
Open

[fmt] Implement --no-ignore-vcs #969

ken-matsui opened this issue Aug 12, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ken-matsui
Copy link
Member

Like poac lint ignores gitignored files by default, poac fmt also wants to ignore those files. Also, we want --no-ignore-vcs to disable this default behavior.

https://github.com/poac-dev/poac/blob/f32c76033c9d70f7b36440e36590c30fda5930ce/src/Cmd/Lint.cc#L37-L49

@ken-matsui ken-matsui added the good first issue Good for newcomers label Aug 12, 2024
@ken-matsui ken-matsui added the enhancement New feature or request label Oct 2, 2024
@Processor228
Copy link

Doesn't fmt already support ignoring?
https://github.com/cabinpkg/cabin/blob/main/src/Cmd/Fmt.cc#L67
here, repo.isIgnored() makes this check. It is also strange that cabin lint parses .gitignore itself, only in current directory, which is not ideal, because in subdirectories, other .gitignore files may be, and files they list would not be excluded. repo.isIngored() is better.

So the issue is just about implementing --no-ignore-vcs flag ?

@ken-matsui
Copy link
Member Author

Yeah looks so

@ken-matsui ken-matsui changed the title [fmt] Ignore gitignored files by default and implement --no-ignore-vcs to disable it [fmt] Implement --no-ignore-vcs Mar 10, 2025
@ken-matsui
Copy link
Member Author

Thanks for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants