You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Like poac lint ignores gitignored files by default, poac fmt also wants to ignore those files. Also, we want --no-ignore-vcs to disable this default behavior.
Doesn't fmt already support ignoring? https://github.com/cabinpkg/cabin/blob/main/src/Cmd/Fmt.cc#L67
here, repo.isIgnored() makes this check. It is also strange that cabin lint parses .gitignore itself, only in current directory, which is not ideal, because in subdirectories, other .gitignore files may be, and files they list would not be excluded. repo.isIngored() is better.
So the issue is just about implementing --no-ignore-vcs flag ?
ken-matsui
changed the title
[fmt] Ignore gitignored files by default and implement --no-ignore-vcs to disable it
[fmt] Implement --no-ignore-vcsMar 10, 2025
Like
poac lint
ignores gitignored files by default,poac fmt
also wants to ignore those files. Also, we want--no-ignore-vcs
to disable this default behavior.https://github.com/poac-dev/poac/blob/f32c76033c9d70f7b36440e36590c30fda5930ce/src/Cmd/Lint.cc#L37-L49
The text was updated successfully, but these errors were encountered: