Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise and simplify event names #2350

Closed
jbrooksuk opened this issue Feb 4, 2017 · 0 comments
Closed

Standardise and simplify event names #2350

jbrooksuk opened this issue Feb 4, 2017 · 0 comments
Labels
Chore Manual labour Refactor
Milestone
v2.4

Comments

@jbrooksuk
Copy link
Member

Now that the event names are playing a more important part in Cachet, we should rename them to standardise and simplify their meaning.

For example:

  • ComponentStatusWasUpdatedEvent could become ComponentStatusChangedEvent.
  • *WasAddedEvent could become *WasCreatedEvent. (Schedule uses the Created scheme, whereas everything was added. Since we use created_at as a column name, it makes sense to follow this instead.
  • IncidentWasReportedEvent should also be IncidentWasCreatedEvent.
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Feb 4, 2017
@jbrooksuk jbrooksuk mentioned this issue Mar 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chore Manual labour Refactor
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@jbrooksuk