-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for integration with others services #36
Comments
You mean update a status from HipChat? Or post a notification to HipChat when something changes? |
Post notifications into HipChat/Send email/SMS/WhatsApp/Facebook. W/e, just make an interface to notify others services. |
What does "enjoy" means? Haha. Btw, we can make it using events of laravel. Bind an listener event for new issues, closed issues and status updates. |
The |
@manavo did you decide on how you want third-parties to integrate via the API? Basic Auth is ok for users, but a service should be given a unique token IMHO. |
SMS could be provided with a Twilio adapter. |
We can use even an Whatsapp API :) |
@pedrommone I've updated your issue to include a task list |
Well, do we actually need the 3rd party to authenticate? It's the other way around, we're posting to them. So we'd need a way to save the auth tokens and endpoints of each service we can notify. But not a way for them to authenticate. Or have I understood this wrong? |
That's a very good point actually. A |
Yep, something along those lines. Just gets annoying because each one has different parameters |
See #44 |
One way of doing it... In the settings table you have enabled/disabled fields for each service... So lets say WhatsApp is enabled. In your services table, just have a column which is a hashed serialized array of the options for each service. This way, you can create an interface which each service must follow, and one such method could be |
@Ehesp that's exactly what I did in the pull request I've just made. |
Great minds.... |
👍 |
FYI, I've not created a model until you repository changes are merged in. |
Now all we need is an abstract class for handling services, then the connectors are simply making the desired requests. We can also cheat here as we can use events for when a model is updated. As soon as we see |
The |
If someone wants to take this up that'd be cool. Otherwise I'll probably push it back till after the First Milestone. |
Would be nice if we can receive a status from HipChat or w/e.
The text was updated successfully, but these errors were encountered: