-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Elixir pre-commits #292
Adding support for Elixir pre-commits #292
Conversation
@atavistock do you want to fix this PR? |
Yes, just haven't been able to circle back to it. Will have more time
later this week.
…On Tue, Jun 6, 2023 at 4:19 AM Domen Kožar ***@***.***> wrote:
@atavistock <https://github.com/atavistock> do you want to fix this PR?
—
Reply to this email directly, view it on GitHub
<#292 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFOBN376ZZNH4EOVF5X5TXJ4G4TANCNFSM6AAAAAAXOOWIXU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@domenkozar Fixed the typos and updated to match current |
Looks like a close bracket was lost, now fixed. |
Okay, only on the OS/X tests its getting:
This far beyond my OS/X and Nix knowledge. Is this something anyone else has seen before? I will try to dig into this but I'm not sure I will be able to in a reasonable time. |
You'll need to rebase on top of master. |
Ping :) |
As far as I can tell,
Checking the How is this supposed to work? Can you somehow configure type tags manually? (Couldn't find anything obvious on pre-commit.com) |
Submitted a PR to However,
|
Adds support for common Elixir precommit hooks
Two of these are built-in to Elixir itself but two are added via a mix file. I've added both
credo
anddialyzer
by hand to my environment using Elixir mix, and I'm not sure if theres a reasonable way to check for them.