Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcaddy build failure #4

Closed
zhzy0077 opened this issue Nov 14, 2024 · 4 comments · Fixed by #5
Closed

xcaddy build failure #4

zhzy0077 opened this issue Nov 14, 2024 · 4 comments · Fixed by #5

Comments

@zhzy0077
Copy link

Repro
xcaddy build --with github.com/caddy-dns/tencentcloud

Expected
Successfully build.

Actual

2024/11/14 17:09:01 [INFO] exec (timeout=0s): /home/zhizhen/bin/go/go/bin/go get -v
2024/11/14 17:09:03 [INFO] Build environment ready
2024/11/14 17:09:03 [INFO] Building Caddy
2024/11/14 17:09:03 [INFO] exec (timeout=0s): /home/zhizhen/bin/go/go/bin/go mod tidy -e
2024/11/14 17:09:04 [INFO] exec (timeout=0s): /home/zhizhen/bin/go/go/bin/go build -o /home/zhizhen/caddy -ldflags -w -s -trimpath -tags nobadger,nomysql,nopgx
# github.com/caddyserver/caddy/v2
/home/zhizhen/go/pkg/mod/github.com/caddyserver/caddy/v2@v2.8.4/context.go:541:12: undefined: zapslog.HandlerOptions
2024/11/14 17:09:04 [INFO] Cleaning up temporary folder: /tmp/buildenv_2024-11-14-1708.1373625778
2024/11/14 17:09:04 [FATAL] exit status 1
@kkkgo
Copy link

kkkgo commented Nov 18, 2024

I am experiencing the same issue and error as described. I have been using GitHub Actions to automatically build Caddy with this plugin. However, since around two weeks ago, the build process consistently fails when including this plugin.

@wangzexi
Copy link

wangzexi commented Nov 20, 2024

When I revert this merge, everything's fine.

xcaddy build --with github.com/caddy-dns/tencentcloud=github.com/wangzexi/tencentcloud@master

Hope @ysicing have a look.

@CameronMunroe
Copy link

The current tagged release is still broken it seems.

If the master branch is working, could we create a new tag against it as that is the default spot for the xcaddy builder to pull from.

@ysicing
Copy link
Contributor

ysicing commented Nov 22, 2024

When I revert this merge, everything's fine.

xcaddy build --with github.com/caddy-dns/tencentcloud=github.com/wangzexi/tencentcloud@master

Hope @ysicing have a look.

Okay, I'll take a look at it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants