Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster non cryptographic hash for load balancing #6201

Closed
jadidbourbaki opened this issue Mar 28, 2024 · 1 comment
Closed

Faster non cryptographic hash for load balancing #6201

jadidbourbaki opened this issue Mar 28, 2024 · 1 comment
Labels
feature ⚙️ New feature or request

Comments

@jadidbourbaki
Copy link
Contributor

I have changed the non cryptographic hash used by Caddy from fnv1 to xxhash, which is known to have better throughput than the FNV family of hashes (https://github.com/Cyan4973/xxHash). Was wondering if there is any comments on creating a PR for this change to the main caddy branch? Just a suggestion, looking to find ways to contribute to the caddy project. Love y'all's work. :-)

https://github.com/jadidbourbaki/caddy/commit/de2a2f6dbc50b3ce59467dfa377a69216f9f18e3

@mholt
Copy link
Member

mholt commented Mar 29, 2024

Neat, I haven't heard about xxhash, but @cespare's library looks good to me. I like Caleb's work; he's a very talented developer so I'm sure it'll be a suitable dependency for our project.

Feel free to submit a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants