fix: call Header.Height as function in logger (cosmos#723)

Fixes cosmos#722.

Author: tzdybal

block/manager.go

@@ -238,7 +238,7 @@ func (m *Manager) SyncLoop(ctx context.Context, cancel context.CancelFunc) {
 			block := blockEvent.block
 			daHeight := blockEvent.daHeight
 			m.logger.Debug("block body retrieved from DALC",
-				"height", block.Header.Height,
+				"height", block.Header.Height(),
 				"daHeight", daHeight,
 				"hash", block.Hash(),
 			)
@@ -557,14 +557,14 @@ func (m *Manager) publishBlock(ctx context.Context) error {
 }
 
 func (m *Manager) submitBlockToDA(ctx context.Context, block *types.Block) error {
-	m.logger.Info("submitting block to DA layer", "height", block.Header.Height)
+	m.logger.Info("submitting block to DA layer", "height", block.Header.Height())
 
 	submitted := false
 	backoff := initialBackoff
 	for attempt := 1; ctx.Err() == nil && !submitted && attempt <= maxSubmitAttempts; attempt++ {
 		res := m.dalc.SubmitBlock(ctx, block)
 		if res.Code == da.StatusSuccess {
-			m.logger.Info("successfully submitted Rollkit block to DA layer", "rollkitHeight", block.Header.Height, "daHeight", res.DAHeight)
+			m.logger.Info("successfully submitted Rollkit block to DA layer", "rollkitHeight", block.Header.Height(), "daHeight", res.DAHeight)
 			submitted = true
 		} else {
 			m.logger.Error("DA layer submission failed", "error", res.Message, "attempt", attempt)

da/mock/mock.go

@@ -73,7 +73,7 @@ func (m *DataAvailabilityLayerClient) Stop() error {
 // triggers a state transition in the DA layer.
 func (m *DataAvailabilityLayerClient) SubmitBlock(ctx context.Context, block *types.Block) da.ResultSubmitBlock {
 	daHeight := atomic.LoadUint64(&m.daHeight)
-	m.logger.Debug("Submitting block to DA layer!", "height", block.Header.Height, "dataLayerHeight", daHeight)
+	m.logger.Debug("Submitting block to DA layer!", "height", block.Header.Height(), "dataLayerHeight", daHeight)
 
 	hash := block.Header.Hash()
 	blob, err := block.MarshalBinary()