Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same color representation for all EPD #124

Open
peckpeck opened this issue Nov 6, 2022 · 2 comments
Open

Use the same color representation for all EPD #124

peckpeck opened this issue Nov 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@peckpeck
Copy link
Contributor

peckpeck commented Nov 6, 2022

The user has to know how EPD implements colors because tricolors have split buffers and the user has to handle it if she doesn't use Display structures.

Moreover Display structures also have to know this too (see the hacky bwrbit in the structure, or the DisplayColorRendering).

I think it should be the only responsibility of epd structures to handle this, we should present a common simple buffer format ti the user for all epds and the specific epd structures should adapt the bits they send to their specific case.

@caemor caemor added the enhancement New feature or request label Nov 28, 2022
@caemor
Copy link
Owner

caemor commented Nov 28, 2022

👍 Combined with the color definition update this would be great usability update.

@peckpeck
Copy link
Contributor Author

peckpeck commented Dec 6, 2022

I'm not sure anymore bout this.
This only impacts users of tricolor epd, and it means having to split data buffers which can be compute intensive.
Moreover, almost only people disabling embedded-graphics could be interested in this, and they are the most likely to be cpu constrained.

So i'm starting to consider leaving the epd methods mostly unchanged, but instead move all color hacks into the colors structures so that the Display structure can abstract them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants