Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate notifications to a group when nightly job fails #393

Closed
jkarpen opened this issue Oct 9, 2024 · 4 comments
Closed

Investigate notifications to a group when nightly job fails #393

jkarpen opened this issue Oct 9, 2024 · 4 comments
Assignees

Comments

@jkarpen
Copy link
Collaborator

jkarpen commented Oct 9, 2024

Email from Andrew came in asking about the ability to send a notification to a group of dbt devs when the nightly job fails. CARB is using dbt core instead of cloud so they are relying on GitHub actions. Currently only the person who submitted the last PR is receiving the notification.

The goal for this issue is to investigate whether and how this is possible (notifying a group when the nightly job fails).

Relevant Doc: https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/about-notifications

@ram-kishore-odi
Copy link
Contributor

Hi @jkarpen @ian-r-rose @britt-allen @summer-mothwood

Can you please review the following document and let me know if you have any feedback before we send it to Andrew ?

https://docs.google.com/document/d/1K8L-lci-0AjuPzbviANYS6lTXgtzUY7QEsAfKeuupps/edit?usp=drive_link

@ian-r-rose
Copy link
Member

@ram-kishore-odi apologies for the extremely slow review! This looks great, and I think we can send it to the CARB team as-is. I'm happy to send it and CC you if you like, or if you want to do it that works as well.

There are a few things that they probably can't do as-written (they don't have gmail, and can't use third-party actions), but I think that's okay, the approaches here should be adaptable to any of a number of situations

@ram-kishore-odi
Copy link
Contributor

@ian-r-rose No problem at all ! thank you for reviewing the document and sharing your feedback. I have updated the document based to add an additional note to address your comments which are all very valid in my view.

I think it will be better for you to share it with the CARB team. Please go ahead.

@ian-r-rose
Copy link
Member

Closing as complete, thanks @ram-kishore-odi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants