Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate storybook min/max control options #350

Closed
1 task done
rocketnova opened this issue Jul 30, 2021 · 1 comment
Closed
1 task done

Investigate storybook min/max control options #350

rocketnova opened this issue Jul 30, 2021 · 1 comment
Assignees
Labels
Engineering Technology and Development Track

Comments

@rocketnova
Copy link
Contributor

rocketnova commented Jul 30, 2021

Description

It appears that the Storybook min and max control options on the number control doesn't prevent you from entering a number that is outside the range.

See #345 (comment)

Acceptance Criteria

  • Spend a little time understanding if this is the expected behavior.
@rocketnova rocketnova added the Engineering Technology and Development Track label Jul 30, 2021
@rocketnova
Copy link
Contributor Author

@lomky I looked into this and confirmed that the configuration is correct. I think the min/max is only for using the control (up and down arrows) itself, but doesn't put any restrictions on typing directly in the box.

Closing this as expected behavior. Feel free to re-open if you feel strongly about it. An alternative we can consider is to use the range control, which represents the number as a slider. I thought this was a less accessible interface, so I didn't initially choose it.

@rocketnova rocketnova self-assigned this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Technology and Development Track
Projects
None yet
Development

No branches or pull requests

1 participant