Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle corrupted prompts at load time #31

Open
joerunde opened this issue Sep 19, 2023 · 0 comments
Open

Handle corrupted prompts at load time #31

joerunde opened this issue Sep 19, 2023 · 0 comments
Assignees

Comments

@joerunde
Copy link
Contributor

joerunde commented Sep 19, 2023

Describe the bug

When caikit uses load_prompt_artifacts to copy over a prompt model's artifacts, there is no error handling if the files themselves are corrupted, so the load will succeed from caikit's perspective, but the model will be unusable in TGIS.

Sample Code

This is a logic bug, so we've never actually made it happen, but it could!

Expected behavior

If the prompt artifacts are corrupted and result in an unusable prompt in TGIS, an error should be reported so that the caikit load function can error out correctly.

@gabe-l-hart gabe-l-hart changed the title fix loads re decoder.pt Handle corrupted prompts at load time Sep 19, 2023
@gabe-l-hart gabe-l-hart self-assigned this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ToDo
Development

No branches or pull requests

2 participants