Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for BIGINT Identity Columns #10

Closed
pagner opened this issue Apr 14, 2023 · 4 comments
Closed

Feature Request: Add support for BIGINT Identity Columns #10

pagner opened this issue Apr 14, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@pagner
Copy link

pagner commented Apr 14, 2023

Currently the library only supports INT identity columns. Would be nice to support BIGINT for different design scenarios. i.e. multi-tenant SAAS applications. GUIDS are another use case, but probably not easy to implement.

Thanks!

@cajuncoding
Copy link
Owner

Thanks, this is a good idea for feature enhancement. SQL Server does support various integer based numeric data types as IDENTITY columns, so it would make sense to support them.

But GUID is not supported as an IDENTITY column since it cannot be incremented automatically…this would be a design choice to use a GUID, and there are some significant cons to using it even as a Primary Key, but the application layer would likely generate these therefore SqlBulkHelpers would already support this just like it does for any other data type ✅.

@cajuncoding cajuncoding added the enhancement New feature or request label Apr 14, 2023
@cajuncoding cajuncoding self-assigned this Apr 14, 2023
@pagner
Copy link
Author

pagner commented Apr 14, 2023

Sorry I should have described the GUID use case better as a primary key. I was thinking the library could generate relations based on a GUID rather than the identity column. I am seeing this design more frequently as of late in lieu of the identity column. I am guessing that is a can of worms though ;-)

This framework here uses GUIDS by default instead of identity columns. You can however use int and bigint.

Thanks again for this library. I look forward to future releases.

@cajuncoding
Copy link
Owner

cajuncoding commented May 23, 2023

This is now implemented ✅ and merged into main pending an upcoming release bundled with some other features; merged via PR #11

@cajuncoding
Copy link
Owner

cajuncoding commented May 24, 2023

Now released with v2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants