Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify setting FileVersion and InformationalVersion #2031

Closed
gabrielweyer opened this issue Feb 3, 2018 · 0 comments
Closed

Simplify setting FileVersion and InformationalVersion #2031

gabrielweyer opened this issue Feb 3, 2018 · 0 comments
Milestone

Comments

@gabrielweyer
Copy link
Contributor

Currently if I want to set the MSBuild FileVersion and InformationalVersion properties this is the code I have to write:

new DotNetCoreMSBuildSettings()
    .SetVersion(assemblyVersion)
    .WithProperty("FileVersion", packageVersion)
    .WithProperty("InformationalVersion", packageVersion)
    .WithProperty("nowarn", "7035");

There is no helper for setting FileVersion and InformationalVersion and as I use semantic versioning I get a compilation warning:

image

What I would like to be able to write is:

new DotNetCoreMSBuildSettings()
    .SetVersion(assemblyVersion)
    .SetFileVersion(packageVersion)
    .SetInformationalVersion(packageVersion)
    .SuppressVersionRecommendedFormatWarning();
@gabrielweyer gabrielweyer changed the title Simplify setting FileVersion and InformationalVersion Simplify setting FileVersion and InformationalVersion Feb 3, 2018
@gep13 gep13 added this to the v0.27.0 milestone Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants