Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended changes resulting from automated audit #4

Closed
4 tasks done
Jericho opened this issue Jun 5, 2018 · 3 comments
Closed
4 tasks done

Recommended changes resulting from automated audit #4

Jericho opened this issue Jun 5, 2018 · 3 comments
Assignees
Milestone

Comments

@Jericho
Copy link

Jericho commented Jun 5, 2018

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.16.2. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
  • Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.
  • The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

@kitgrose
Copy link

The current version of Cake refuses to include Cake.AppPackager because of point 1 above.

@phillipsj
Copy link
Owner

@kitgrose I apologize for you running.into.this.issue. I will get this updated and published this week.

@phillipsj phillipsj self-assigned this Sep 16, 2018
@phillipsj phillipsj added this to the 0.11.0 milestone Sep 16, 2018
@phillipsj
Copy link
Owner

@kitgrose I have version 0.11.0 and 0.11.1 both out on NuGet. The 0.11.1 is just correcting the missing XML documentation. https://www.nuget.org/packages/Cake.AppPackager/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants