Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomProjectParserResult.OutputPaths doesn't respect AppendTargetFrameworkToOutputPath #174

Closed
wnorvelleadc opened this issue Jan 6, 2022 · 1 comment · Fixed by #175
Assignees
Labels
Milestone

Comments

@wnorvelleadc
Copy link
Contributor

CustomProjectParserResult.OutputPaths doesn't respect the AppendTargetFrameworkToOutputPath property in csproj files

Expected Behavior

The output path for a project with AppendTargetFrameworkToOutputPath set to false should be, for example, "bin/Debug"

Current Behavior

Independent of what AppendTargetFrameworkToOutputPath is set to, the output path will have the target framework appended, for example, "bin/Debug/net48"

Steps to Reproduce (for bugs)

For this project file:
<Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <TargetFramework>net48</TargetFramework> <Deterministic>False</Deterministic> <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> <OutputType>Exe</OutputType> </PropertyGroup> </Project>

  1. Use projectFile.ParseProjectFile(configuration: "debug") to parse the file
  2. CustomProjectParserResult.OutputPaths.First() will end in "bin/debug/net48" rather than "bin/debug"

Context

Need to be able to know where the dll will end up for use later in our build pipeline.

Your Environment

  • Module version used: 6.0.0
  • Operating System and PowerShell version: Windows 10, PowerShell 7.1.3
@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants