(GH-117) Add support for npm dist-tag #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalberger
force-pushed
the
develop
branch
4 times, most recently
from
c97a047
to
c7f5ec2
Compare
pascalberger
changed the title
pascalberger
requested changes
Aug 29, 2020
There was a problem hiding this comment.
Instead of having an enum in the settings (and some settings which don't make sense depending on the selected command), I would prefer to have separate aliases for the different calls. Also should contain test cases, documentation of the whole public API and code style consistent with the project.
This was referenced Aug 29, 2020
pascalberger
force-pushed
the
develop
branch
5 times, most recently
from
1e102b2
to
45f072e
Compare
pascalberger
force-pushed
the
develop
branch
2 times, most recently
from
1e2d419
to
332429b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed to add dist-tag, get the npm config and view pushed packages so i made these commands.
Fixes #117