Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cake.Yarn to target Cake v2.0.0 #44

Closed
paulmilbank opened this issue May 26, 2022 · 2 comments · Fixed by #42
Closed

Update Cake.Yarn to target Cake v2.0.0 #44

paulmilbank opened this issue May 26, 2022 · 2 comments · Fixed by #42
Assignees
Milestone

Comments

@paulmilbank
Copy link
Contributor

#42

Can this be upgraded to Cake 2.0? All tests pass locally, but obviously it would lose support for running on dotnet 4.8 and below only build agents. I tried it with multi targeting for dotnet core 3.1 and net6.0 and it works fine, so I can add that to the PR if needed. Now net5.0 is out of support, it doesn't seem worth targeting that framework too.

@paulmilbank
Copy link
Contributor Author

Forgot to say, I added net5.0 as a target as Cake still supports it currently.

@augustoproiete augustoproiete added this to the v1.0.0 milestone Dec 24, 2022
@augustoproiete augustoproiete linked a pull request Dec 24, 2022 that will close this issue
@augustoproiete augustoproiete changed the title Upgrade to Cake 2.0 Update Cake.Yarn to target Cake v2.0.0 Dec 24, 2022
@augustoproiete
Copy link
Member

🎉 The changes implemented in response to this issue shipped with Cake.Yarn v1.0.0

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants