Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the active flags FALSE by default #1742

Closed
3 tasks
thekaveman opened this issue Sep 20, 2023 · 1 comment
Closed
3 tasks

Make the active flags FALSE by default #1742

thekaveman opened this issue Sep 20, 2023 · 1 comment
Assignees
Labels
bug Something isn't working chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.

Comments

@thekaveman
Copy link
Member

thekaveman commented Sep 20, 2023

We saw an issue where a race condition between the app code being deployed but new secrets/app settings not ready yet, and SBMTD was showing as an active agency briefly.

Acceptance Criteria

Each of these lines uses False by default

@thekaveman thekaveman added bug Something isn't working chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. labels Sep 20, 2023
@thekaveman thekaveman mentioned this issue Sep 20, 2023
13 tasks
@thekaveman thekaveman self-assigned this Sep 21, 2023
@thekaveman thekaveman moved this from Todo to In Progress in Digital Services Sep 21, 2023
@thekaveman thekaveman added this to the Admin tool: v1 milestone Sep 21, 2023
@thekaveman
Copy link
Member Author

In testing this with a PR (see #1746) it became clear that our UI / Cypress tests are dependent on the default values being True.

This should be changed wholesale as we look to implement an Admin/Config interface, where our tests could run against a true sample agency CST, and we'll have an easier time flipping real agencies on/off.

Closing for now as we've moved passed the initial issue and have the False values configured in each environment.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Digital Services Sep 21, 2023
@thekaveman thekaveman closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant