Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon doesn't show up on the Superuser's admin #2443

Closed
lalver1 opened this issue Oct 9, 2024 · 2 comments · Fixed by #2497
Closed

favicon doesn't show up on the Superuser's admin #2443

lalver1 opened this issue Oct 9, 2024 · 2 comments · Fixed by #2497
Assignees
Labels
bug Something isn't working

Comments

@lalver1
Copy link
Member

lalver1 commented Oct 9, 2024

Maybe need a future ticket: The favicon doesn't show up on the superuser homepage, but it does for the other admin pages: log in, log out, in-person flow pages.

image

Originally posted by @machikoyasuda in #2430 (comment)

The favicon is not showing up in the Superuser's admin page, but it seems like we can use the extrahead block of the admin app's base.html template to include it. So we may need to override the admin/index.html template and include the icon in the extrahead block.

@lalver1 lalver1 changed the title favicon doesn't show up on the superuser's admin favicon doesn't show up on the Superuser's admin Oct 9, 2024
@lalver1 lalver1 added the bug Something isn't working label Oct 9, 2024
@thekaveman thekaveman moved this from Todo to Stretch in Digital Services Oct 9, 2024
@ohmegasquared
Copy link

Image

I explored an admin favicon option - using black Cal ITP style with the benefits label.

@srhhnry what do you think about this option?

favicon_io.zip

@srhhnry
Copy link

srhhnry commented Oct 16, 2024

This is great! What a cool idea. Branding is not exactly my strength, but I wonder if we need the Cal-ITP blue on the Benefits banner? All black makes more aesthetic sense to me, but maybe both would be nice to have?

@lalver1 lalver1 moved this from Stretch to In review in Digital Services Nov 1, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants