Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails for 4.8.1 #18232

Open
nebulade opened this issue Dec 17, 2024 · 2 comments
Open

Build fails for 4.8.1 #18232

nebulade opened this issue Dec 17, 2024 · 2 comments
Labels
🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore. self-hosting

Comments

@nebulade
Copy link
Contributor

The current version 4.8.1 fails during building for selfhosting. This worked fine with the previous version, looks like just some type issues:

@calcom/web:build:    Linting and checking validity of types ...
@calcom/web:build: 
@calcom/web:build: Failed to compile.
@calcom/web:build: 
@calcom/web:build: ./app/WithAppDirSsg.tsx
@calcom/web:build: 5:29  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 
@calcom/web:build: ./app/WithAppDirSsr.tsx
@calcom/web:build: 5:29  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 
@calcom/web:build: ./app/WithEmbedSSR.tsx
@calcom/web:build: 12:69  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 
@calcom/web:build: ./app/future/apps/[slug]/[...pages]/page.tsx
@calcom/web:build: 39:56  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 
@calcom/web:build: ./app/layout.tsx
@calcom/web:build: 87:11  Error: Dangerous property 'dangerouslySetInnerHTML' found  react/no-danger
@calcom/web:build: 
@calcom/web:build: ./app/layoutHOC.tsx
@calcom/web:build: 9:48  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 19:53  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 
@calcom/web:build: ./app/workflows/page.tsx
@calcom/web:build: 16:23  Warning: 'params' is defined but never used. Allowed unused args must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 16:31  Warning: 'searchParams' is defined but never used. Allowed unused args must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./pages/api/auth/two-factor/totp/disable.ts
@calcom/web:build: 26:90  Warning: Do not pass argument object with include: { AnyPropertyName: true } to prisma methods  @calcom/eslint/no-prisma-include-true
@calcom/web:build: 
@calcom/web:build: ./pages/api/auth/two-factor/totp/setup.ts
@calcom/web:build: 28:90  Warning: Do not pass argument object with include: { AnyPropertyName: true } to prisma methods  @calcom/eslint/no-prisma-include-true
@calcom/web:build: 
@calcom/web:build: ./pages/api/cron/downgradeUsers.ts
@calcom/web:build: 22:9  Warning: 'delay' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./components/apps/AppPage.tsx
@calcom/web:build: 169:6  Warning: React Hook useEffect has missing dependencies: 'mutation', 'searchParams', 'slug', 'type', and 'variant'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps
@calcom/web:build: 
@calcom/web:build: ./components/dialog/ReassignDialog.tsx
@calcom/web:build: 60:14  Warning: 'ReassignDialog' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./components/dialog/RerouteDialog.tsx
@calcom/web:build: 182:6  Warning: React Hook useEffect has a missing dependency: 'state?.reschedulerWindow?.closed'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
@calcom/web:build: 238:5  Warning: React Hook useCallback has missing dependencies: 'router' and 't'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps
@calcom/web:build: 245:6  Warning: React Hook useCallback has a missing dependency: 'reroutingState'. Either include it or remove the dependency array.  react-hooks/exhaustive-deps
@calcom/web:build: 316:13  Warning: Forbidden non-null assertion.  @typescript-eslint/no-non-null-assertion
@calcom/web:build: 349:23  Warning: 'ctx' is defined but never used. Allowed unused args must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 756:9  Warning: 'router' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./components/dialog/__tests__/RerouteDialog.test.tsx
@calcom/web:build: 10:16  Warning: 'path' is defined but never used. Allowed unused args must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 24:37  Warning: 'response' is defined but never used. Allowed unused args must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 25:37  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 43:35  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 87:39  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 238:79  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 310:7  Warning: 'buildBooking' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./components/settings/SecondaryEmailModal.tsx
@calcom/web:build: 50:6  Warning: React Hook useEffect has missing dependencies: 'clearErrorMessage' and 'formMethods'. Either include them or remove the dependency array. If 'clearErrorMessage' changes too often, find the parent component that defines it and wrap that definition in useCallback.  react-hooks/exhaustive-deps
@calcom/web:build: 
@calcom/web:build: ./lib/apps/[slug]/[...pages]/getServerSideProps.ts
@calcom/web:build: 64:37  Warning: Unexpected any. Specify a different type.  @typescript-eslint/no-explicit-any
@calcom/web:build: 
@calcom/web:build: ./lib/apps/[slug]/getStaticProps.tsx
@calcom/web:build: 13:7  Warning: 'md' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./lib/getTeamMemberEmailFromCrm.ts
@calcom/web:build: 60:34  Warning: 'eventTypeId' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./lib/team/[slug]/[type]/getServerSideProps.tsx
@calcom/web:build: 31:67  Warning: 'email' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
@calcom/web:build: ERROR: command finished with error: command (/app/code/apps/web) yarn run build exited (1)
command (/app/code/apps/web) yarn run build exited (1)

Since similar issues happened quite a bit in the past, I am wondering if for selfhosted builds, other eslint rules apply and may need to be relaxed?

@nebulade nebulade added the 🐛 bug Something isn't working label Dec 17, 2024
@dosubot dosubot bot added self-hosting 📉 regressing This used to work. Now it doesn't anymore. labels Dec 17, 2024
@xcellentavi
Copy link

This is an ongoing issue and is being investigated: #17638

@keithwillcode let us know if a fix is expected soon, thank you!

@Praashh Praashh added the Medium priority Created by Linear-GitHub Sync label Dec 20, 2024
@ArcadaLabs-Jason
Copy link

ArcadaLabs-Jason commented Dec 20, 2024

+1 for latest, just stepping backward through version tags to attempt to get one that actually builds..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore. self-hosting
Projects
None yet
Development

No branches or pull requests

4 participants