Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1006] Experiment: try dashboard as SPA vs SSR #6935

Closed
PeerRich opened this issue Feb 8, 2023 · 0 comments · Fixed by #6936
Closed

[CAL-1006] Experiment: try dashboard as SPA vs SSR #6935

PeerRich opened this issue Feb 8, 2023 · 0 comments · Fixed by #6936
Assignees
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync 🚧 wip / in the making This is currently being worked on
Milestone

Comments

@PeerRich
Copy link
Member

PeerRich commented Feb 8, 2023

Posted by @KATT

Heya 👋 come the [suspense](http://app.cal.com|app.cal.com> dashboard is server-side rendered? I feel it would feel faster if you did SPA there and you'd ship faster since it would unlock being able to use <https://trpc.io/docs/suspense) etc

Below is a almost 3s blocking request when toggling between "Availability" and "Booking"

Like, my suggestion would be to get rid of this stuff:

export const getServerSideProps = async (context: GetServerSidePropsContext) => {
const ssr = await ssrInit(context);
return {
props: {
trpcState: ssr.dehydrate(),
},
};
};

IIRC that stuff is there because of i18n-flicker, but I'm sure there's an alternative way of dealing with that

Suspense (Experimental) | tRPC

<https://github.com/calcom/cal.com/blob/8c150264f498b8e5d5cfedaebc69465c1dfd2aeb/apps/web/pages/availability/index.tsx | index.tsx>

From SyncLinear.com | CAL-1006

@PeerRich PeerRich self-assigned this Feb 8, 2023
@PeerRich PeerRich added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Feb 8, 2023
@PeerRich PeerRich linked a pull request Feb 8, 2023 that will close this issue
@PeerRich PeerRich added this to the 2.6 milestone Feb 8, 2023
@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync 🚧 wip / in the making This is currently being worked on labels Feb 17, 2023
@PeerRich PeerRich modified the milestones: 2.6, 2.7 Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync 🚧 wip / in the making This is currently being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant