Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1127] [CAL-192] "&" symbol and apostrophes don't get rendered properly in the confirmation email title #7255

Closed
milospuac opened this issue Feb 21, 2023 · 24 comments
Assignees
Labels
🙋🏻‍♂️help wanted Help from the community is appreciated Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Milestone

Comments

@milospuac
Copy link
Contributor

milospuac commented Feb 21, 2023

This is the name of the event type

Screenshot 2022-10-19 at 17.27.54.png

And this is how it appears in the email

Screenshot 2022-10-19 at 17.29.45.png

From SyncLinear.com | CAL-192

From SyncLinear.com | CAL-192

@milospuac milospuac changed the title [CAL-192] "&" symbol and apostrophes don't get rendered properly in the confirmation email title [CAL-1127] [CAL-192] "&" symbol and apostrophes don't get rendered properly in the confirmation email title Feb 21, 2023
@milospuac milospuac added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🙋🏻‍♂️help wanted Help from the community is appreciated labels Feb 21, 2023
@milospuac
Copy link
Contributor Author

Screenshot 2022-11-03 at 1.33.47 PM.png

okay so this bug is only on production ( app.cal.com) and not in development. will have to investigate more

@milospuac
Copy link
Contributor Author

Can you try chrome or safari?

@milospuac
Copy link
Contributor Author

brave browser

@milospuac
Copy link
Contributor Author

@Udit-takkar do you use chrome?

@milospuac
Copy link
Contributor Author

perplexed-mystery.gif

@milospuac
Copy link
Contributor Author

Screenshot 2022-10-26 at 10.06.04 PM.png

It's also working fine here

@milospuac
Copy link
Contributor Author

Also, check the bookings tab once you confirmed the meeting

Screenshot 2022-10-26 at 18.32.52.png

@milospuac
Copy link
Contributor Author

okay maybe this problem is only in confirmed email

@milospuac
Copy link
Contributor Author

Screenshot 2022-10-26 at 9.59.52 PM.png

I have also tested on browser

@milospuac
Copy link
Contributor Author

Hey @Udit-takkar it's both gmail and outlook

Gmail:

Screenshot 2022-10-26 at 18.01.31.png

Outlook:

Screenshot 2022-10-26 at 18.00.18.png

I do have to mention that this is in the browser, don't know how it behaves in apps for those platforms.

@milospuac
Copy link
Contributor Author

i have tested on gmail, outlook

@milospuac
Copy link
Contributor Author

Screenshot 2022-10-26 at 5.29.55 PM.png

i am unable to reproduce this bug. what email provider are you using ?

@ciaranha
Copy link
Member

@Udit-takkar did you get anywhere with this? This is still an issue for me but with forward slash/
CleanShot 2023-02-21 at 15 40 19@2x

You can book here to test if you need to: https://cal.com/ciaran/design

@ciaranha ciaranha added Medium priority Created by Linear-GitHub Sync and removed Low priority Created by Linear-GitHub Sync labels Feb 21, 2023
@Udit-takkar
Copy link
Contributor

@Jaibles yeah it's still pending. just busy with few other things will work on this as soon as i can

@G3root
Copy link
Contributor

G3root commented Feb 21, 2023

same as #1961 , #6798 and #3250. for the #3250 i sent a PR , looks like this problem isn't fixed . maybe it's something to do with sendgrid 🤔 ?

@PeerRich
Copy link
Member

very weird

@PeerRich
Copy link
Member

@leog maybe you have an idea?

@PeerRich
Copy link
Member

or @CarinaWolli

@leog
Copy link
Contributor

leog commented Feb 22, 2023

@leog maybe you have an idea?

I will need to have a deeper look when I get back on Monday, but take a look at this @Udit-takkar: https://stackoverflow.com/a/53487408/1644038

@CarinaWolli
Copy link
Member

maybe it's something to do with SendGrid 🤔 ?

I don't think it has anything to do with SendGrid, I just set up SendGrid locally and everything is still working.

Some findings I had:

  • Booking title on production db is saved with "Design / product review" but event title on production is saved as "Design / product review"
  • Locally the booking title is saved as "Design / product review"

Anybody any idea why?

@leog
Copy link
Contributor

leog commented Feb 22, 2023

Anybody any idea why?

@CarinaWolli Different db encodings perhaps?

@G3root
Copy link
Contributor

G3root commented Feb 23, 2023

@CarinaWolli does wrapping email subject with decodeURIComponent fix this ?

@CarinaWolli
Copy link
Member

@CarinaWolli does wrapping email subject with decodeURIComponent fix this ?

@G3root No it doesn't

Another thing I found: If you use your own custom event name (advanced settings - Event name in calendar ) then the special characters are also working fine. So I think the issue is because of this translation:
Screenshot 2023-02-23 at 10 53 14

i18next escapes values, see here: https://www.i18next.com/translation-function/interpolation#unescape
No idea though, why this is not happening locally

@G3root
Copy link
Contributor

G3root commented Apr 19, 2023

fixed by #7591

@G3root G3root closed this as completed Apr 19, 2023
@milospuac milospuac added this to the v.2.9 milestone Apr 19, 2023
@milospuac milospuac closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋🏻‍♂️help wanted Help from the community is appreciated Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Development

No branches or pull requests

7 participants