Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test for Embeds is Failing #7565

Closed
ShaneMaglangit opened this issue Mar 7, 2023 · 1 comment · Fixed by #7573
Closed

E2E Test for Embeds is Failing #7565

ShaneMaglangit opened this issue Mar 7, 2023 · 1 comment · Fixed by #7573
Assignees

Comments

@ShaneMaglangit
Copy link
Contributor

Issue Summary

A change that is merged on the main branch seems to be causing an E2E to fail and has been affecting multiple PRs.

https://github.com/calcom/cal.com/actions/runs/4355954491
https://github.com/calcom/cal.com/actions/runs/4356847979

Steps to Reproduce

  1. Start a fresh project from the main branch.
  2. In /event-types, select an event and click the ••• icon and click embed.
  3. Select any of the three options and go to the preview tab.
  4. This should render nothing and there would be an error in the console from zod saying that eventPage is undefined.

This accurately demonstrates what the E2E test for embeds is complaining about.

Technical details

  • Browser: Chrome
  • Node.js: 18
  • Version: Latest main
@emrysal
Copy link
Contributor

emrysal commented Mar 7, 2023

This actually seem to be two separate issues:

  • One is the embeds test, it's very flaky (and doesn't seem to retry) - causing the embed test to fail; but it does pass (sometimes) an example of this passing is in here: fix: event location not translated in booking page #7528
  • The second one is a bug that seems to have been introduced in a PR last week, I can't see a negative effect of that bug (besides the console error)

Assigned @CarinaWolli to have a looksy at the console error 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants